feat(core): more rules #2107
Merged
feat(core): more rules #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippietrail
reviewed
Oct 27, 2025
| ["all of the sudden", "all of sudden", "all the sudden"], | ||
| ["all of a sudden", "all of the sudden"], | ||
| "Prefer the phrasing `all of a sudden` or `all of the sudden`.", | ||
| "Guides this expression toward `all of a sudden` or `all of the sudden`.", |
Collaborator
There was a problem hiding this comment.
"All of the sudden" is nonstandard. I only know it from the internet. I think it's regional but not sure from where. Plenty of discussion about it vs standard "all of a sudden" on the internet:
- https://www.merriam-webster.com/grammar/usage-of-all-of-a-sudden
- https://www.grammarly.com/blog/commonly-confused-words/all-of-a-sudden/
- https://quillbot.com/blog/common-mistakes/all-of-a-sudden/
- https://www.rd.com/article/all-of-the-sudden-vs-all-of-a-sudden/
I would think we shouldn't recommend it. But if we must we definitely should present it is less standard than "all of a sudden".
Vinzent03
pushed a commit
to Vinzent03/harper
that referenced
this pull request
Nov 5, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 10, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.70.0` -> `v0.71.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.71.0`](https://github.com/Automattic/harper/releases/tag/v0.71.0) [Compare Source](Automattic/harper@v0.70.0...v0.71.0) #### What's Changed - build(deps): bump clap from 4.5.48 to 4.5.50 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2112](Automattic/harper#2112) - build(deps): bump getrandom from 0.3.3 to 0.3.4 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2113](Automattic/harper#2113) - feat(vscode): support more platforms by [@​mcecode](https://github.com/mcecode) in [#​2116](Automattic/harper#2116) - feat: introduce stale bot by [@​elijah-potter](https://github.com/elijah-potter) in [#​2117](Automattic/harper#2117) - Add wasm-bindgen-cli to nix flake by [@​bjtitus](https://github.com/bjtitus) in [#​2108](Automattic/harper#2108) - fix(core): refine acronym detection in `AnA` by [@​86xsk](https://github.com/86xsk) in [#​2109](Automattic/harper#2109) - feat(core): create `SplitWords` linter by [@​elijah-potter](https://github.com/elijah-potter) in [#​2118](Automattic/harper#2118) - Change tact by [@​hippietrail](https://github.com/hippietrail) in [#​2130](Automattic/harper#2130) - feat: quite many→quite a few by [@​hippietrail](https://github.com/hippietrail) in [#​2129](Automattic/harper#2129) - Fix typo in front page FAQ by [@​adamchainz](https://github.com/adamchainz) in [#​2125](Automattic/harper#2125) - build(deps): bump clap from 4.5.50 to 4.5.51 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2127](Automattic/harper#2127) - feat: sync language support by [@​mcecode](https://github.com/mcecode) in [#​2123](Automattic/harper#2123) - feat: passerbys→passersby by [@​hippietrail](https://github.com/hippietrail) in [#​2135](Automattic/harper#2135) - chore: reduce dependency load for new contributors by [@​elijah-potter](https://github.com/elijah-potter) in [#​2131](Automattic/harper#2131) - feat(web): Add testimonials by [@​elijah-potter](https://github.com/elijah-potter) in [#​2139](Automattic/harper#2139) - feat(core): more rules by [@​elijah-potter](https://github.com/elijah-potter) in [#​2107](Automattic/harper#2107) - feat: let/lets `<pronoun>` to do→let/lets `<pronoun>` do by [@​hippietrail](https://github.com/hippietrail) in [#​2140](Automattic/harper#2140) - feat:a lot of/most of the times→time by [@​hippietrail](https://github.com/hippietrail) in [#​2141](Automattic/harper#2141) - fix(obsidian): ignore files by [@​Vinzent03](https://github.com/Vinzent03) in [#​2143](Automattic/harper#2143) - fix: "reservation" annotations; issue [#​2120](Automattic/harper#2120) by [@​hippietrail](https://github.com/hippietrail) in [#​2134](Automattic/harper#2134) - feat(chrome-ext): 'block rule' button by [@​elijah-potter](https://github.com/elijah-potter) in [#​2145](Automattic/harper#2145) - fix: `description` and `message` were copypasted from another linter! by [@​hippietrail](https://github.com/hippietrail) in [#​2147](Automattic/harper#2147) - feat: redundant "after <duration> later" by [@​hippietrail](https://github.com/hippietrail) in [#​2146](Automattic/harper#2146) #### New Contributors - [@​bjtitus](https://github.com/bjtitus) made their first contribution in [#​2108](Automattic/harper#2108) - [@​adamchainz](https://github.com/adamchainz) made their first contribution in [#​2125](Automattic/harper#2125) - [@​Vinzent03](https://github.com/Vinzent03) made their first contribution in [#​2143](Automattic/harper#2143) **Full Changelog**: <Automattic/harper@v0.70.0...v0.71.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #2043 and possibly #1836
Description
Several new grammatical rules. I suggest you look through the code to see which have been added and why. The tests may prove enlightening.
How Has This Been Tested?
Additional unit tests
Checklist